Review of "Bitcoin Markets" version 60

Details Page Preview

Display info on various crypto-currency exchanges.

Extension Homepage
https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Line 200 (extension.js), you should remove the timeout on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. I see the timeout in line 907 (extension.js) is getting removed on `PollLoop.stop()`. Please add PollLoop.stop() trace back for the next version review (when the extension get disabled). 3. Use ExtensionUtils.openPrefs() instead spawn command (extension.js line 83). If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions