Review of "Astra Monitor" version 1

Details Page Preview

Astra Monitor is a cutting-edge, fully customizable, and performance-focused system monitoring extension for GNOME's top bar. It's an all-in-one solution for those seeking to keep a close eye on their system's performance metrics like CPU, GPU, RAM, disk usage, network statistics, and sensor readings.

Extension Homepage
https://github.com/AstraExt/astra-monitor

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 (46) Active
28 (45) Active
27 (44) Active
26 (43) Active
25 (42) Active
24 (41) Active
24 (40) Rejected
24 (39) Inactive
23 (38) Active
23 (37) Rejected
22 (36) Active
21 (35) Active
21 (34) Inactive
21 (33) Rejected
21 (32) Rejected
20 (31) Rejected
19 (30) Active
18 (29) Active
18 (28) Inactive
17 (27) Active
16 (26) Inactive
16 (25) Rejected
15 (24) Active
14 (23) Active
14 (22) Rejected
14 (21) Rejected
13 (20) Active
12 (19) Active
11 (18) Active
10 (17) Inactive
10 (16) Rejected
10 (15) Rejected
10 (14) Rejected
9 (13) Active
9 (12) Inactive
8 (11) Active
7 (10) Active
7 (9) Rejected
6 (8) Active
5 (7) Active
4 (6) Active
3 (5) Active
2 (4) Active
1 (3) Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No need to use `this.initTranslation()`: - line 36 `extension.js` - line 34 `prefs.js` > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. Don't hold instances of objects as static if you don't want to clean that up in disable or window close request: - line 41 `extension.js` - line 39 `prefs.js` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) btw, for `prefs.js`, window close request signal is: ```js window.connect('close-request', () => { // destroy and null up here }); ``` 3. Wrong gettext domain (line 2 `schemas/org.gnome.shell.extensions.astra-monitor.gschema.xml`). 4. Unused imports: - line 20 `src/monitor.js` - line 19 `src/menu.js` - line 26 `src/header.js` - line 22 `src/grid.js` - line 20, 24 `src/graph.js` - line 21 `src/storage/storageGraph.js` - line 18 `src/sensors/sensorsMonitor.js` - line 18, 20 `src/sensors/sensorsMenu.js` - line 18 `src/memory/memoryMonitor.js` 5. `lookupByUUID()` is a bad practice (line 110 `src/menu.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection).