Review of "Media Progress" version 1

Details Page Preview

Progress Bar for the GNOME Media Notification

Extension Homepage
https://github.com/Krypion17/media-progress

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Active
8 Rejected
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't call functions and methods in global scope (line 11-15 `progressBar.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 2. Timeouts should be removed on destroy (line 94 and 116 `progressBar.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Please use a less generic name for the default class you are exporting in `extension.js`. 4. Please clear intervals, timeouts and destroy in the same class you are creating not in another module (line 24-34 `extension.js`). After creating `destroy()` function for that class, you can simply do this in `extension.js`: ```js this.media_section?.destroy(); this.media_section = null; ``` Also do the same for `progressBarManager` class (line 19-21 `extension.js`). 5. Selective disable is not allowed (line 16-17 `extension.js`): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions