Review of "Media Progress" version 29

Details Page Preview

Progress Bar for the GNOME Media Notification

Extension Homepage
https://github.com/Krypion17/media-progress

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
JustPerfection posted a review
Please avoid using unnecessary try and catch blocks.
Krypion17 posted a review
This one is a bit complicated. A user had reported an issue that I wasn't able to reproduce consistently. I had pushed a commit that seemed to fix it on my end but they reported issues and tried to fix it themselves. The additional try catch ones were from that commit, and since I am unable to verify which ones fix the problem, I left them as a kind of blanket solution.
JustPerfection posted a review
What's the user error in the logs?
Krypion17 posted a review
The error reported was `Error: No signal connection undefined found`
JustPerfection posted a review
Are you sure the dbus call is successful (line 231 `progressBar.js`)? Also, make sure the `this._busName` is correct in that call.
Krypion17 posted a review
As per the freedesktop specs (https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Method:SetPosition), the dbus call never seems to fail. It always says something along the lines of no effect. I don't think the issue is in that function though. Is there any significant performance issue with retaining the try catch statements? It only runs when destroy is called. I'll also be submitting a gnome 48 version with the same fixes.