Review of "Tiling Shell" version 11 (14)

Details Page Preview

Extend Gnome Shell with advanced tiling window management. Supports multiple monitors, Windows 11 Snap Assistant, Fancy Zones, customised tiling layouts and more.

Extension Homepage
https://github.com/domferr/tilingshell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15.1 (43) Active
15.1 (42) Active
15.1 (41) Rejected
15.0 (40) Active
15.0 (39) Active
15.0 (38) Rejected
14.1 (37) Active
14.1 (36) Active
14.1 (35) Rejected
14 (34) Active
14 (33) Active
14 (32) Inactive
14 (31) Rejected
13.1 (30) Active
13.1 (29) Active
13.0 (28) Active
13.0 (27) Active
12.2 (26) Active
12.2 (25) Active
12.1 (24) Active
12.1 (23) Active
12 (22) Active
12 (21) Active
12 (20) Inactive
12 (19) Inactive
11.1 (18) Active
11.1 (17) Active
11 (16) Active
11 (15) Active
11 (14) Rejected
10.0 (13) Active
10.0 (12) Active
9.1 (11) Active
9.1 (10) Active
9.0 (9) Active
9.0 (8) Active
8.0 (7) Active
8.0 (6) Active
5 Active
4 Active
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You cannot import `Gtk` and `Gdk` in the GNOME Shell process (line 2906 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell)
domferr posted a review
Hi! Thank you for your review. Gtk and Gdk on line 2906 are not imported in the GNOME Shell process, but instead I'm spawning a Gio.Subprocess which uses Gtk and Gdk to obtain the monitor's description. This is more or less what I'm doing: - define a string at line 2906 with the import statements - define a string from line 2907 to line 2916 with the code to be run by the Gio.Subprocess. This string also includes the string created at line 2906 - run a Gio.Subprocess which runs the command gjs -c <code>, where <code> is the string defined from line 2907 Since the Monitor class available in GNOME Shell doesn't have the monitor's description, spawning a subprocess was the only solution I thought to safely leverage on Gdk.Monitor without including Gdk and Gtk in the GNOME shell process. Hope this clarifies, but I'm open to any discussion or suggestion! Thank you once again
JustPerfection posted a review
Move that to another file and start that file with: ```js #!@GJS@ -m ``` Then you can use spawn command for that.