Review of "Quake Terminal" version 1.0.1 (29)

Details Page Preview

Quickly launch a terminal in Quake mode using a keyboard shortcut

Extension Homepage
https://github.com/diegodario88/quake-terminal

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.0.3 (32) Active
1.0.2 (31) Active
1.0.1 (30) Active
1.0.1 (29) Active
1.6.9 (28) Active
1.6.9 (27) Active
1.6.8 (26) Rejected
1.6.6 (25) Active
1.6.6 (24) Active
1.6.5 (23) Active
1.6.4 (22) Active
1.6.3 (21) Rejected
1.6.3 (20) Active
1.6.2 (19) Active
1.6.1 (18) Active
1.6.1 (17) Active
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
For line 759 `extension.js`, is it going to work for uppercase words? because it is `g` not `gi`.
JustPerfection posted a review
I meant `quake-mode.js`.
carcara posted a review
Hey, that's a great question! (I hate regex btw) The reason the i flag is not used is due to the specific requirements of the Desktop Entry Specification. - The character set [fFuUdDnNickv] explicitly includes both the lowercase and uppercase variants for the field codes that have a case-sensitive meaning, specifically f, u, d, and n (for example, both %f and %F are valid but have different meanings). - For the other codes (i, c, k, and v), the specification only defines the lowercase versions. Using the case-insensitive (i) flag would incorrectly match and remove non-standard or undefined uppercase codes (like %I or %C) which a specific command might actually rely on. In short, the current implementation is correct because it is precise: it only removes the specific field codes defined as removable by the specification.
JustPerfection active
Ok, approved! Thanks!