Review of "All-in-One Clipboard" version 3

Details Page Preview

A powerful clipboard manager that combines your clipboard history, emojis, GIFs, kaomojis, and symbols into a single, searchable interface. External Services: • Klipy & Tenor - GIF search and browsing • Google S2 Favicons - Favicon fallback for URLs • Cloudflare Workers - API key storage Extension Homepage: https://github.com/NiffirgkcaJ/all-in-one-clipboard https://gitlab.com/NiffirgkcaJ/all-in-one-clipboard

Extension Homepage
https://github.com/NiffirgkcaJ/all-in-one-clipboard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You already have `window` in the `fillPreferencesWindow()` that you can use instead (line 453 `prefs.js`). If you did that because of the window close cleanup, you can do: ```js window.connect('close-request', () => { // clean up here }); ``` But `page.get_root()` is also okay if you still prefer that. 2. Timeout should be removed on destroy and before creating a new one: - line 245, 497 `extension.js` - line 523 `utilities/utilityCategorizedItemViewer.js` - line 254 `features/Clipboard/logic/clipboardManager.js` - line 798 `features/RecentlyUsed/tabRecentlyUsed.js` - line 24 `utilities/utilityAutoPaste.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. You shouldn't create instances of objects in global scope: - line 10 `features/GIF/logic/gifManager.js` - line 26 `features/GIF/tabGIF.js` - line 18 `features/RecentlyUsed/tabRecentlyUsed.js` Breaking two rules: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. You should call `abort()` on disable or destroy: [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 6. You cannot import `Gtk` and `Gdk` to the GNOME Shell process: - line 1, 6 `features/GIF/tabGIF.js` - line 5 `utilities/utilityCategorizedItemViewer.js` - line 5 `features/RecentlyUsed/tabRecentlyUsed.js` [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 7. Add to the description that this extension is using Google Tenor and `imgur.com` services.