Review of "All-in-One Clipboard" version 27

Details Page Preview

A powerful clipboard manager that combines your clipboard history, emojis, GIFs, kaomojis, and symbols into a single, searchable interface. External Services: • Klipy & Tenor - GIF search and browsing • Google S2 Favicons - Favicon fallback for URLs • Cloudflare Workers - API key storage Extension Homepage: https://github.com/NiffirgkcaJ/all-in-one-clipboard https://gitlab.com/NiffirgkcaJ/all-in-one-clipboard

Extension Homepage
https://github.com/NiffirgkcaJ/all-in-one-clipboard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • shared/utilities/utilityClipboard.js:10
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:23
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:36
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:51
    St.Clipboard.get_default()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • features/Clipboard/constants/clipboardLayoutConstants.js
  • features/Clipboard/integrations/clipboardMenuDefinition.js
  • features/Clipboard/services/clipboardSearchService.js
  • features/Clipboard/services/clipboardSelectionService.js
  • features/Clipboard/tabClipboard.js
  • features/Clipboard/utilities/clipboardKeyboardShortcuts.js
  • features/Clipboard/view/clipboardActionBar.js
  • features/Clipboard/view/clipboardBaseItemConfig.js
  • features/Clipboard/view/clipboardBaseView.js
  • features/Clipboard/view/clipboardBaseWidgetFactory.js
  • features/Clipboard/view/clipboardGridItemFactory.js
  • features/Clipboard/view/clipboardGridView.js
  • features/Clipboard/view/clipboardListItemFactory.js
  • features/Clipboard/view/clipboardListView.js
  • features/Emoji/integrations/emojiMenuDefinition.js
  • features/Emoji/tabEmoji.js
  • features/GIF/integrations/gifMenuDefinition.js
  • features/GIF/services/gifDownloadService.js
  • features/GIF/services/gifFetchService.js
  • features/GIF/services/gifHttpService.js

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
What's the reason for using `?.()`?
NiffirgkcaJ posted a review
It was done to prevent crashes on the recently used module, if the integrations haven't been loaded yet. On the next update, I'll amend it.
JustPerfection active
Approved this one but please cleanup all the unnecessary checks for the next version.