Review of "All-in-One Clipboard" version 11

Details Page Preview

A powerful clipboard manager that combines your clipboard history, emojis, GIFs, kaomojis, and symbols into a single, searchable interface. External Services: • Klipy & Tenor - GIF search and browsing • Google S2 Favicons - Favicon fallback for URLs • Cloudflare Workers - API key storage Extension Homepage: https://github.com/NiffirgkcaJ/all-in-one-clipboard https://gitlab.com/NiffirgkcaJ/all-in-one-clipboard

Extension Homepage
https://github.com/NiffirgkcaJ/all-in-one-clipboard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy and before creating a new one: - line 209 `extension.js` - line 848 `features/RecentlyUsed/tabRecentlyUsed.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. You should call `abort()` on destroy and don't forget to call destroy on the instance: - line 47, 112 `features/Clipboard/processors/clipboardLinkProcessor.js` - line 15 `features/GIF/logic/gifDownloadService.js` [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. What's the reason for not importing at the top of the file (line 245 `features/RecentlyUsed/view/recentlyUsedViewRenderer.js`)? If that's for avoiding the import into the shell process when it is not needed, GNOME Shell already imported `Soup` to the process, before your extension is getting loaded.