GNOME Shell Extensions

Review of "All-in-One Clipboard" version 22

Details Page Preview

All-in-One Clipboard

by NiffirgkcaJ

A powerful clipboard manager that combines your clipboard history, emojis, GIFs, kaomojis, and symbols into a single, searchable interface. External Services: • Klipy & Tenor - GIF search and browsing • Google S2 Favicons - Favicon fallback for URLs • Cloudflare Workers - API key storage Extension Homepage: https://github.com/NiffirgkcaJ/all-in-one-clipboard https://gitlab.com/NiffirgkcaJ/all-in-one-clipboard

Extension Homepage
https://github.com/NiffirgkcaJ/all-in-one-clipboard
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • shared/utilities/utilityClipboard.js:10 
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:23 
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:36 
    St.Clipboard.get_default()
  • shared/utilities/utilityClipboard.js:51 
    St.Clipboard.get_default()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • features/Clipboard/constants/clipboardLayoutConstants.js
  • features/Clipboard/integrations/clipboardMenuDefinition.js
  • features/Clipboard/services/clipboardSearchService.js
  • features/Clipboard/services/clipboardSelectionService.js
  • features/Clipboard/tabClipboard.js
  • features/Clipboard/utilities/clipboardKeyboardShortcuts.js
  • features/Clipboard/view/clipboardActionBar.js
  • features/Clipboard/view/clipboardBaseItemConfig.js
  • features/Clipboard/view/clipboardBaseView.js
  • features/Clipboard/view/clipboardBaseWidgetFactory.js
  • features/Clipboard/view/clipboardGridItemFactory.js
  • features/Clipboard/view/clipboardGridView.js
  • features/Clipboard/view/clipboardListItemFactory.js
  • features/Clipboard/view/clipboardListView.js
  • features/Emoji/integrations/emojiMenuDefinition.js
  • features/Emoji/tabEmoji.js
  • features/GIF/integrations/gifMenuDefinition.js
  • features/GIF/services/gifDownloadService.js
  • features/GIF/services/gifFetchService.js
  • features/GIF/services/gifHttpService.js

All Versions

Version Status
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Rejected
21 Rejected
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy (line 317 `features/Clipboard/services/clipboardCopyService.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Duplicating code is bad. You already have `isCallable` in `shared/services/serviceSearchHub.js`.