Review of "Live Tennis Monitor" version 4

Details Page Preview

A Gnome extension that helps you show live tennis scores. Service provider: atptour.com and wtatennis.com

Extension Homepage
https://github.com/homebackend/gnome-live-tennis

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. #6 from previous review hasn't been addressed here. Call `this._destroyCycleTimeout();` before line 1479 `extension.js`. 2. Remove `LiveScorePreferences.constructor()` and you shouldn't get schemas like that when you already have `this.getSettings()`. - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. As mentioned before, `httpSession.abort()` should be called on disable. You are simply calling it on `finally`.