Review of "Live Tennis Monitor" version 5

Details Page Preview

A Gnome extension that helps you show live tennis scores. Service provider: atptour.com and wtatennis.com

Extension Homepage
https://github.com/homebackend/gnome-live-tennis

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Unreviewed
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You shouldn't create instance of objects in global scope (line 230-250 `prefs.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Use white spaces between functions and classes. It's really hard to review without them.
slashblog posted a review
1. I will take case of #1, once you review the code fully. 2. The code is generated from typescript, so I am not sure inserting white spaces is possible. However you can review changes from: https://github.com/homebackend/gnome-live-tennis. Look in the src directory. Hope this helps.
JustPerfection posted a review
To make the diff smaller, first, fix the #1 and send the fixed version here. Then you can use prettier for #2.
slashblog posted a review
Ok uploading fix for #1.