Review of "Live Tennis Monitor" version 19

Details Page Preview

A Gnome extension that helps you show live tennis scores. Service provider: atptour.com and wtatennis.com

Extension Homepage
https://github.com/homebackend/gnome-live-tennis

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
19 Unreviewed
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

slashblog posted a review
I have been using htmlparser2 to parse html files. Due to its dependence on node.js, recent updates made it difficult to use it with Gnome shell extension. As a result I have switched to https://www.npmjs.com/package/htmlparser2-without-node-native. In a previous review I got the following comments in review: https://extensions.gnome.org/review/72845: You cannot use obfuscated data like that (line 2988-2992 `extension.js`): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#code-must-not-be-obfuscated [Answer]: I don't use obfuscated code/data. It is from htmlparser2 itself. Please consider that. I have moved htmlparser2 code to a separate file: htmlparser2/index.js so that it is clearly visible. Also htmlparser2/index.js is generated by esbuild from original so that it can be used by my shell extension code. Please avoid sending large diff. The review queue is really busy, large diff could wait for a long time. [Answer] Sorry my changes themselves are not that big they appear so because I changed htmlparser. Hopefully code changes should appear less daunting now. Thanks.
slashblog posted a review
I have been using htmlparser2 to parse html files. Due to its dependence on node.js, recent updates made it difficult to use it with Gnome shell extension. As a result I have switched to https://www.npmjs.com/package/htmlparser2-without-node-native. In a previous review I got the following comments in review: https://extensions.gnome.org/review/72845: You cannot use obfuscated data like that (line 2988-2992 `extension.js`): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#code-must-not-be-obfuscated [Answer]: I don't use obfuscated code/data. It is from htmlparser2 itself. Please consider that. I have moved htmlparser2 code to a separate file: htmlparser2/index.js so that it is clearly visible. Also htmlparser2/index.js is generated by esbuild from original so that it can be used by my shell extension code. Please avoid sending large diff. The review queue is really busy, large diff could wait for a long time. [Answer] Sorry my changes themselves are not that big they appear so because I changed htmlparser. Hopefully code changes should appear less daunting now. Thanks.