Review of "Live Tennis Monitor" version 12

Details Page Preview

A Gnome extension that helps you show live tennis scores. Service provider: atptour.com and wtatennis.com

Extension Homepage
https://github.com/homebackend/gnome-live-tennis

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:1415
    this._item = new PopupMenu.PopupMenuItem("", { reactive: true })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:1386
    this._menu = new PopupMenu.PopupSubMenuMenuItem(properties.text, true)
  • extension.js:1415
    this._item = new PopupMenu.PopupMenuItem("", { reactive: true })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:661
        closeButton.connect("clicked", () => {
          console.log("Close clicked");
        })
  • extension.js:1464
    this._item.connect(action, handler)
  • extension.js:1496
    this._item.connect(action, handler)
  • extension.js:4710
    this._panelButton.connect("manual-refresh", () => this._updater.fetchMatchData())
  • extension.js:4709
    this._panelButton.connect("open-prefs", () => this.openPreferences())

All Versions

Version Status
19 Unreviewed
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

slashblog auto- rejected
Auto-rejected because of new version 13 was uploaded