Review of "Aurora Shell" version 4

Details Page Preview

A customizable GNOME Shell extension that enhances the user experience with various modules and features.

Extension Homepage
https://github.com/luminusOS/aurora-shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
17 Unreviewed
16 Active
15 Rejected
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use empty lines between functions and classes. 2. Remove line 48 `modules/pipOnTop.js` since that fall into selective disable in later updates. 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (line 79 `extension.js`). 4. `_isDestroyed` is a bad practice, please remove them. 5. Extensions cannot use `run_dispose()` (line 183 `modules/dock.js`): [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 6. Timeout should be removed on destroy (line 460 `modules/dock.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
JustPerfection posted a review
You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)