Review of "Aurora Shell" version 7

Details Page Preview

A customizable GNOME Shell extension that enhances the user experience with various modules and features.

Extension Homepage
https://github.com/luminusOS/aurora-shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
17 Active
16 Active
15 Rejected
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed before creating a new one (line 47 `modules/dock/hotArea.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
leandromqrs posted a review
Give me a some explanation, pls. I put a timeout to check the debounce. The timeout is created, but If has another timeout, it's replaced, not? It's necessary to check if has a timeout in this occasion too? And, in the destroy, it's called too 93 if (this._pointerDwellTimeoutId) { 94 GLib.source_remove(this._pointerDwellTimeoutId); 95 this._pointerDwellTimeoutId = 0; 96 }
JustPerfection posted a review
The destroy cleanup is okay. Just before creating a new one since timeouts can get triggered multiple times in racy situations. Then that can lead to dangling timeouts.
leandromqrs posted a review
Oh, okay! I understand now! :D