Review of "Aurora Shell" version 50.2 (21)

Details Page Preview

A customizable GNOME Shell extension that enhances the user experience with various modules and features. The optional Clipboard History module reads and stores clipboard text locally so it can be browsed and restored; no clipboard data is shared with third parties, and its open shortcut is unset by default.

Extension Homepage
https://github.com/luminusOS/aurora-shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 6 manual_review 1

Shexli found 7 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • modules/clipboardHistory/clipboardHistory.js:120
    St.Clipboard.get_default()
  • modules/clipboardHistory/clipboardMonitor.js:39
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • modules/clipboardHistory/clipboardStore.js:22
    file.load_contents(null)
  • modules/trayIcons/trayIcons.js:250
    GLib.file_get_contents(`/proc/${pid}/root/.flatpak-info`)
  • modules/trayIcons/trayIcons.js:286
    GLib.file_get_contents(`/proc/${pid}/status`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • modules/trayIcons/trayContainer.js:179
          this._chevronIcon = new St.Icon({
            icon_name: 'pan-end-symbolic',
            icon_size: 14,
            style_class: 'aurora-tray-chevron-icon',
          })
  • modules/trayIcons/trayIconItem.js:74
    this._localMenuManager = new PopupMenu.PopupMenuManager(this)
  • modules/trayIcons/trayIconItem.js:66
    this._menuManager = new PopupMenu.PopupMenuManager(this)
  • modules/volumeMixer/mixerPanel.js:38
    this._scroll = scroll

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • core/logger.js:64
    _activeLogger = new ConsoleLogger()
  • core/logger.js:64
    new ConsoleLogger()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • modules/trayIcons/trayContainer.js:179
          this._chevronIcon = new St.Icon({
            icon_name: 'pan-end-symbolic',
            icon_size: 14,
            style_class: 'aurora-tray-chevron-icon',
          })
  • modules/volumeMixer/mixerPanel.js:38
    this._scroll = scroll

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • modules/clipboardHistory/clipboardPanel.js:225
          this._dragEndId = global.stage.connect('button-release-event', () => {
            this._endDrag();
            return Clutter.EVENT_PROPAGATE;
          })
  • modules/clipboardHistory/clipboardPanel.js:222
          this._dragMotionId = global.stage.connect('motion-event', (_actor, evt) =>
            this._onDragMotion(evt),
          )

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • shared/ui/dash.js:589
                  this._springLoadTimerId = GLib.timeout_add(
                    GLib.PRIORITY_DEFAULT,
                    SPRING_LOAD_DELAY,
                    () => {
                      this._springLoadTimerId = 0;
                      if (this._isDestroyed) return GLib.SOURCE_REMOVE;
                      const windo
  • shared/ui/dash.js:729
          this._workAreaUpdateId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
            this._workAreaUpdateId = 0;
            if (this._workArea) {
              this.applyWorkArea(this._workArea);
            }
            return GLib.SOURCE_REMOVE;
          })

All Versions

Version Status
50.6 (24) Active
50.5 (23) Rejected
50.4 (22) Rejected
50.2 (21) Rejected
50.3 (20) Rejected
50.2 (19) Rejected
18 Rejected
17 Active
16 Active
15 Rejected
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

leandromqrs auto- rejected
Auto-rejected because of new version 50.4 (22) was uploaded