Review of "Aurora Shell" version 50.2 (19)

Details Page Preview

A customizable GNOME Shell extension that enhances the user experience with various modules and features.

Extension Homepage
https://github.com/luminusOS/aurora-shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • modules/trayIcons/trayContainer.js:179
          this._chevronIcon = new St.Icon({
            icon_name: 'pan-end-symbolic',
            icon_size: 14,
            style_class: 'aurora-tray-chevron-icon',
          })
  • modules/trayIcons/trayIconItem.js:74
    this._localMenuManager = new PopupMenu.PopupMenuManager(this)
  • modules/trayIcons/trayIconItem.js:66
    this._menuManager = new PopupMenu.PopupMenuManager(this)
  • modules/volumeMixer/mixerPanel.js:37
    this._scroll = scroll

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • core/logger.js:64
    _activeLogger = new ConsoleLogger()
  • core/logger.js:64
    new ConsoleLogger()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • modules/trayIcons/backgroundAppsSource.js:31
    this._appSystem = Shell.AppSystem.get_default()
  • modules/trayIcons/trayContainer.js:179
          this._chevronIcon = new St.Icon({
            icon_name: 'pan-end-symbolic',
            icon_size: 14,
            style_class: 'aurora-tray-chevron-icon',
          })
  • modules/trayIcons/trayIconItem.js:72
    this._localMenu = new PopupMenu.PopupMenu(this, 0.5, St.Side.TOP)
  • modules/trayIcons/trayIconItem.js:74
    this._localMenuManager = new PopupMenu.PopupMenuManager(this)
  • modules/trayIcons/trayIconItem.js:64
    this._menu = new PopupMenu.PopupMenu(this, 0.5, St.Side.TOP)
  • modules/trayIcons/trayIconItem.js:66
    this._menuManager = new PopupMenu.PopupMenuManager(this)
  • modules/volumeMixer/mixerPanel.js:37
    this._scroll = scroll

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • modules/trayIcons/trayContainer.js:408
            GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
              logger.log(
                `Viewport post-allocate chevronX=${Math.round(this._chevron.translationX)} ${this._clipArea.layoutSnapshot()}`,
                { prefix: LOG_PREFIX },
              );
              return GLib.SOURCE_REMOVE;
            })
  • shared/ui/dash.js:589
                  this._springLoadTimerId = GLib.timeout_add(
                    GLib.PRIORITY_DEFAULT,
                    SPRING_LOAD_DELAY,
                    () => {
                      this._springLoadTimerId = 0;
                      if (this._isDestroyed) return GLib.SOURCE_REMOVE;
                      const windo
  • shared/ui/dash.js:729
          this._workAreaUpdateId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
            this._workAreaUpdateId = 0;
            if (this._workArea) {
              this.applyWorkArea(this._workArea);
            }
            return GLib.SOURCE_REMOVE;
          })

All Versions

Version Status
50.3 (20) Unreviewed
50.2 (19) Rejected
18 Rejected
17 Active
16 Active
15 Rejected
14 Rejected
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Rejected
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

leandromqrs auto- rejected
Auto-rejected because of new version 50.3 (20) was uploaded