Stocks Extension brings stock quotes to your GNOME Shell Panel
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 37 | Active |
| 36 | Rejected |
| 35 | Rejected |
| 34 | Rejected |
| 33 | Rejected |
| 32 | Active |
| 31 | Rejected |
| 30 | Active |
| 29 | Active |
| 28 | Active |
| 27 | Rejected |
| 26 | Rejected |
| 25 | Active |
| 24 | Active |
| 23 | Rejected |
| 22 | Rejected |
| 21 | Rejected |
| 20 | Rejected |
| 19 | Active |
| 18 | Active |
| 17 | Active |
| 16 | Rejected |
| 15 | Active |
| 14 | Active |
| 13 | Rejected |
| 12 | Active |
| 11 | Rejected |
| 10 | Active |
| 9 | Active |
| 8 | Active |
| 7 | Rejected |
| 6 | Active |
| 5 | Rejected |
| 4 | Active |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
1. `_destroyed` is a bad practice. Please removed that. 2. As mentioned before, you cannot create instance of objects in global scope (line 6 `helpers/fetch.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
1-2, got it. 3. is gschemas.compiled not considered useful for manual installs? Seems like other active extensions still include it ...
It will be compiled on install time.
What pattern do you expect to see as a replacement for `_destroyed`? FWIW, I just volunteered to take this extension over since it was abandoned a couple of years ago - I'm not the original author.
Once you called `destroy()` on the instance, you should never access the instance again. You should null out the property or variable you are holding that instance. Something `_destroyed` to check whether the destroy has been called before is anti pattern and a bad practice.
I appreciate your patience on this.
Stocks Extension