Review "Stocks Extension" version 38 - GNOME Shell Extensions

Review of "Stocks Extension" version 38

Stocks Extension brings stock quotes to your GNOME Shell Panel

No comments.

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli found 3 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

schemas/org.gnome.shell.extensions.stock.gschema.xml

id='org.gnome.shell.extensions.stocks' path='/org/gnome/shell/extensions/stocks/'

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

extension.js:82

this._mainEventHandler.connect('hide-panel', () => this.menu.close())

extension.js:85

this.menu.connect('destroy', this._destroyExtension.bind(this))

extension.js:86

    this.menu.connect('open-state-changed', (menu, isOpen) => {
      this._mainEventHandler.emit('open-state-changed', { isOpen })
    })

fmuellner active May 11, 2026