Review "Devialet Control" version 1.0.0 (1)

Review of "Devialet Control" version 1.0.0 (1)

by guzu

Control Devialet speakers on your network — volume, playback and device discovery

No comments.

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli found 2 issues that may need reviewer attention.

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

indicator.js:159

device.slider.connect('drag-end', () => this._onVolumeChanged(device))

indicator.js:156

        device.slider.connect('notify::value', () => {
            device.volLabel.text = `${Math.round(device.slider.value * 100)}%`;
        })

indicator.js:68

refreshBtn.connect('clicked', () => this._onRefresh())

guzu auto- rejected April 4, 2026

Auto-rejected because of new version 1.0.1 (2) was uploaded