Review of "Devialet Control" version 1.0.1 (2)

Details Page Preview

Control Devialet speakers on your network — volume, playback and device discovery. This extension is not affiliated, funded, or in any way associated with Devialet.

Extension Homepage
https://github.com/guzu/gnome-extension-devialet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • cache.js:14
    file.load_contents(null)

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:185
    btn.connect('clicked', callback)
  • indicator.js:159
    device.slider.connect('drag-end', () => this._onVolumeChanged(device))
  • indicator.js:156
            device.slider.connect('notify::value', () => {
                device.volLabel.text = `${Math.round(device.slider.value * 100)}%`;
            })
  • indicator.js:68
    refreshBtn.connect('clicked', () => this._onRefresh())

All Versions

Version Status
1.2.3 (10) Active
1.2.3 (9) Inactive
1.2.3 (8) Rejected
1.2.3 (7) Inactive
1.2.2 (6) Rejected
1.2.1 (5) Rejected
1.1.0 (4) Rejected
1.1.0 (3) Rejected
1.0.1 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

guzu auto- rejected
Auto-rejected because of new version 1.1.0 (3) was uploaded