Review of "Devialet Control" version 1.1.0 (3)

Details Page Preview

Control Devialet speakers on your network — volume, playback and device discovery

Extension Homepage
https://github.com/guzu/gnome-extension-devialet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • cache.js:14
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:159
    device.slider.connect('drag-end', () => this._onVolumeChanged(device))
  • indicator.js:156
            device.slider.connect('notify::value', () => {
                device.volLabel.text = `${Math.round(device.slider.value * 100)}%`;
            })

All Versions

Version Status
1.1.0 (4) Unreviewed
1.1.0 (3) Unreviewed
1.0.1 (2) Rejected
1.0.0 (1) Rejected