Review of "Devialet Control" version 1.1.0 (4)

Details Page Preview

Control Devialet speakers on your network — volume, playback and device discovery. This extension is not affiliated, funded, or in any way associated with Devialet.

Extension Homepage
https://github.com/guzu/gnome-extension-devialet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:239
    widget.connect('destroy', () => label.destroy())
  • indicator.js:229
            widget.connect('enter-event', () => {
                const [x, y] = widget.get_transformed_position();
                const widgetWidth = widget.get_width();
                label.set_position(
                    Math.round(x + widgetWidth / 2 - label.get_width() / 2),
                    Math.round(y - labe
  • indicator.js:238
    widget.connect('leave-event', () => label.hide())

All Versions

Version Status
1.2.3 (10) Active
1.2.3 (9) Inactive
1.2.3 (8) Rejected
1.2.3 (7) Inactive
1.2.2 (6) Rejected
1.2.1 (5) Rejected
1.1.0 (4) Rejected
1.1.0 (3) Rejected
1.0.1 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import: - line 1 `devialetClient.js` - line 6 `indicator.js` 2. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with Devialet. 3. You should call `abort()` on destroy (line 20 `devialetClient.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 4. Line 252 `avahiDiscovery.js` falls under selective disable. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions Enjoy the high-end listening ;)
guzu posted a review
Hi, Most of comments were fixed, with the exception of "Line 252 `avahiDiscovery.js` falls under selective disable." that I didn't understand. Thanks for review