Review of "Devialet Control" version 1.1.0 (4)

Details Page Preview

Control Devialet speakers on your network — volume, playback and device discovery

Extension Homepage
https://github.com/guzu/gnome-extension-devialet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:239
    widget.connect('destroy', () => label.destroy())
  • indicator.js:229
            widget.connect('enter-event', () => {
                const [x, y] = widget.get_transformed_position();
                const widgetWidth = widget.get_width();
                label.set_position(
                    Math.round(x + widgetWidth / 2 - label.get_width() / 2),
                    Math.round(y - labe
  • indicator.js:238
    widget.connect('leave-event', () => label.hide())

All Versions

Version Status
1.1.0 (4) Unreviewed
1.1.0 (3) Unreviewed
1.0.1 (2) Rejected
1.0.0 (1) Rejected