Review of "Sound Input & Output Device Chooser" version 44

Details Page Preview

Shows a list of sound output and input devices (similar to gnome sound settings) in the status menu below the volume slider. Various active ports like HDMI , Speakers etc. of the same device are also displayed for selection. V20+ needs python as dependency. If you want to continue with the old method without Python, use options to switch off New Port identification. But it works with only English

Extension Homepage
https://github.com/kgshank/gse-sound-output-device-chooser

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-I-001 error

deprecated modules must not be imported

Deprecated module `ByteArray` is imported.

Do not use deprecated modules

  • convenience.js:19
    ByteArray = imports.byteArray

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gtk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • prefs.js:19
    { Gio, GObject, Gtk } = imports.gi

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • base.js:247
    this._settings = ExtensionUtils.getSettings()
  • base.js:243
    this.menuItem = new PopupMenu.PopupSubMenuMenuItem(_("Extension initialising..."), true)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • base.js:121
                    pItem.connect('activate', () => {
                        _d("Activating Profile:" + id + profileName);
                        this.emit("profile-activated", this.id, profileName);
                    })

All Versions

Previous Reviews on this Version

fmuellner active