Review of "Rounded Window Corners Reborn" version 16

Details Page Preview

Add rounded corners to all windows. Fork of the now unmaintained Rounded Window Corners extension.

Extension Homepage
https://github.com/flexagoon/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • utils/background_menu.js:39
    Extension.lookupByURL(import.meta.url)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/file.js:12
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • utils/types.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:70
            prefs.connect('changed', (_, key) => {
                if (key === 'enable-preferences-entry') {
                    getPref('enable-preferences-entry')
                        ? enableBackgroundMenuItem()
                        : disableBackgroundMenuItem();
                }
            })

All Versions

Version Status
24 Rejected
23 Active
22 Active
21 Active
20 Rejected
19 Rejected
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

flexagoon auto- rejected
Auto-rejected because of new version 17 was uploaded