Review of "Rounded Window Corners Reborn" version 20

Details Page Preview

Add rounded corners to all windows. Fork of the now unmaintained Rounded Window Corners extension.

Extension Homepage
https://github.com/flexagoon/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/file.js:12
    file.load_contents(null)

All Versions

Version Status
21 Active
20 Rejected
19 Rejected
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

flexagoon posted a review
I know there's a Shexli issue for using synchronous file read, but fixing it would require marking half the codebase as async for something that is essentially only executed once on startup so doesn't have any performance effect
JustPerfection rejected
Sync spawn can freeze the shell process. Please fix that.