GNOME Shell Extensions

Review of "Lock Keys" version 69

Details Page Preview

Lock Keys

by kazimieras.vaina

Numlock & Capslock status on the panel.

Extension Homepage
https://github.com/kazysmaster/gnome-shell-extension-lockkeys
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO014 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:272 
    this.iconTheme = new St.IconTheme()

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:272 
    this.iconTheme = new St.IconTheme()

All Versions

Version Status
69 Unreviewed
68 Active
67 Active
66 Active
65 Active
64 Active
63 Active
62 Active
61 Active
60 Active
59 Active
58 Active
57 Active
56 Active
55 Active
54 Active
53 Rejected
52 Active
51 Active
50 Active
49 Active
48 Active
47 Active
46 Rejected
45 Active
44 Active
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Rejected
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Inactive
3 Active
2 Active
1 Inactive