Review of "Compiz windows effect" version 30

Details Page Preview

Compiz wobbly windows effect ----------------------------------- Video ----------------------------------- https://youtu.be/G8bAVIB9A7A

Extension Homepage
https://github.com/hermes83/compiz-windows-effect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:131
    actor.metaWindow.get_maximized()

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:52
    this.presetComboBox = this.addPresetComboBox(group1, "Preset", settingsData)
  • prefs.js:53
    this.frictionSlider = this.addSlider(group1, "Friction", settingsData.FRICTION, 1.0, 10.0, 1)
  • prefs.js:54
    this.springKSlider = this.addSlider(group1, "Spring", settingsData.SPRING_K, 1.0, 10.0, 1)
  • prefs.js:55
    this.speedupFactor = this.addSlider(group1, "Speedup Factor", settingsData.SPEEDUP_FACTOR, 2.0, 40.0, 1)
  • prefs.js:56
    this.massSlider = this.addSlider(group1, "Mass", settingsData.MASS, 20.0, 80.0, 0)
  • prefs.js:60
    this.xTilesSlider = this.addSlider(group2, "X Tiles", settingsData.X_TILES, 3.0, 20.0, 0)
  • prefs.js:61
    this.yTilesSlider = this.addSlider(group2, "Y Tiles", settingsData.Y_TILES, 3.0, 20.0, 0)
  • prefs.js:62
    this.maximizeEffectSwitch = this.addBooleanSwitch(group2, "Maximize effect", settingsData.MAXIMIZE_EFFECT)
  • prefs.js:63
    this.resizeEffectSwitch = this.addBooleanSwitch(group2, "Resize effect", settingsData.RESIZE_EFFECT)

All Versions

Previous Reviews on this Version

hermes83 posted a review
fixed "error" and warnings in version 31
fmuellner active
fmuellner active