Review of "Show Desktop Button" version 50

Details Page Preview

Minimize/unminimize all open windows with a single click.

Extension Homepage
https://github.com/amivaleo/Show-Desktop-Button

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO012 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.showdesktopbutton.gschema.xml
    expected_filename='org.gnome.shell.extensions.show-desktop-button.gschema.xml'

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:289
    		Settings.connect('changed::hover-preview', () => {
                previewDesktop(false);
            })
  • extension.js:285
    		Settings.connect('changed::indicator-icon-name', () => {
    			removeButton();
    			addButton();
    		})
  • extension.js:281
    		Settings.connect('changed::indicator-position', () => {
    			removeButton();
    			addButton();
    		})
  • extension.js:276
    		Settings.connect('changed::keep-focused', () => {
    			resetToggleStatus();
    			removeButton();
    			addButton();
    		})
  • extension.js:237
    panelButton.connect('button-press-event', toggleDesktop)
  • extension.js:239
        panelButton.connect('enter-event', () => {
            if (Settings.get_boolean('hover-preview')) {
                previewDesktop(true);
            }
        })
  • extension.js:244
        panelButton.connect('leave-event', () => {
            if (Settings.get_boolean('hover-preview')) {
                previewDesktop(false);
            }
        })
  • extension.js:238
    panelButton.connect('touch-event', toggleDesktop)

All Versions

Previous Reviews on this Version

amivaleo auto- rejected
Auto-rejected because of new version 51 was uploaded