Review of "Custom Reboot" version 13

Details Page Preview

Reboot into another OS directly from GNOME. A expansion of https://github.com/docquantum/gnome-shell-extension-customreboot

Extension Homepage
https://github.com/Nova1545/gnome-shell-extension-customreboot

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • grub.js:24
    file.load_contents(null)

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.extensions.customreboot.gschema.xml
    id='org.gnome.shell.extensions.customreboot' path='/org/gnome/shell/extensions/customreboot/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:150
    this.menu = new RebootQuickMenu(this)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:33
            this.menuClosedID = this.menu.connect("menu-closed", () => {
                this.checked = false;
            })

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

SuperNova1909 posted a review
fmuellner active