Review of "Bowser Gnome Extension" version 18

Details Page Preview

Create rules to open specific websites in specific web browsers for links clicked in any application on your computer. (emails, chat etc)

Extension Homepage
https://github.com/blipk/bowser-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:116
    GLib.spawn_command_line_sync( "xdg-desktop-menu install " + fileUtils.CONF_DIR() + "/bowser-gnome.desktop --novendor" )
  • extension.js:512
    GLib.spawn_command_line_sync( "xdg-settings get default-web-browser" )
  • extension.js:520
    GLib.spawn_command_line_sync( "xdg-settings set default-web-browser " + browser )

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • fileUtils.js:214
    file.load_contents( null )
  • inputValidator.js:21
    file.load_contents( null )

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • bowser.js

All Versions

Version Status
18 Active
17 Active
16 Inactive
15 Rejected
14 Rejected
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Inactive

Previous Reviews on this Version

fmuellner active