Review of "AATWS (Advanced Alt-Tab Window Switcher)" version 50.0 (65)

Details Page Preview

A highly customizable replacement for Alt/Super+Tab window/app switchers that offers a 'type to search' mode, various filtering and sorting options, workspace and monitor navigation, configurable hotkeys for navigation and window/app control, and an app launcher. AATWS also provides mouse control and can be used as a replacement for dock extensions in auto-hide configuration. Please note that GNOME has three built-in window switcher popups, and this extension replaces all of them. The first one groups windows by applications and is used as the default in vanilla GNOME distributions. The second one offers a window list, and the third one displays windows of the currently focused application. You can set keyboard shortcuts for all the switchers in GNOME Settings application. For more information and bug reports, please follow the link below. Keywords: alttab, search, find, window search, popup delay, applications, apps, dock, monitor, thumbnail, preview, move windows, launch app, switch, VIM.

Extension Homepage
https://github.com/G-dH/advanced-alttab-window-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • src/actions.js:287
    metaWin.maximize(Meta.MaximizeFlags.BOTH)
  • src/actions.js:300
    metaWin.maximize(Meta.MaximizeFlags.BOTH)
  • src/actions.js:283
    metaWin.unmaximize(Meta.MaximizeFlags.BOTH)
  • src/actions.js:295
    metaWin.unmaximize(Meta.MaximizeFlags.BOTH)
  • src/windowMenu.js:82
    window.maximize(Meta.MaximizeFlags.BOTH)
  • src/windowMenu.js:75
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • src/actions.js:279
    metaWin.get_maximized()
  • src/actions.js:338
    win.get_maximized()
  • src/switcherItems.js:238
    this.window.get_maximized()
  • src/switcherList.js:384
    item.window.get_maximized()
  • src/windowMenu.js:71
    window.get_maximized()
  • src/windowMenu.js:100
    window.get_maximized()

EGO-I-004 warning

extensions should not use imports._gi directly

Direct use of `imports._gi` is discouraged in extensions.

InjectionManager

  • src/util.js:22
    imports._gi
  • src/util.js:60
    Gi.hook_up_vfunc_symbol
  • src/util.js:85
    Gi.gobject_prototype_symbol

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:75
    this._opt.connect('changed', this._updateSettings.bind(this))
  • extension.js:268
    pressureBarrier.connect('trigger', this._onPressureTriggered.bind(this, Main.layoutManager.monitors[i]))

All Versions

Version Status
50.0 (65) Active
49.0 (64) Active
48.1 (63) Active
48.0 (62) Inactive
44.10 (61) Active
44.10 (60) Rejected
47.2 (59) Active
44.10 (58) Rejected
47.1 (57) Active
47.0 (56) Inactive
46.2 (55) Active
46.1 (54) Inactive
46.1 (53) Inactive
44.9 (52) Active
46.0 (51) Inactive
46.0 (50) Rejected
45.6 (49) Active
44.8 (48) Active
44.8 (47) Inactive
45.6 (46) Inactive
44.8 (45) Inactive
45.6 (44) Inactive
45.6 (43) Inactive
44.8 (42) Inactive
44.8 (41) Inactive
45.6 (40) Inactive
44.7 (39) Inactive
45.5 (38) Inactive
44.6 (37) Inactive
45.4 (36) Inactive
44.5 (35) Inactive
45.3 (34) Inactive
44.4 (33) Inactive
44.3 (32) Inactive
45.2 (31) Inactive
27.45 (30) Inactive
27.45 (29) Rejected
27.45 (28) Rejected
27.45 (27) Rejected
26 Active
25 Rejected
24 Inactive
23 Rejected
22 Inactive
21 Inactive
20 Inactive
19 Rejected
18 Inactive
17 Inactive
16 Inactive
15 Inactive
14 Inactive
13 Rejected
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

fmuellner active