GNOME Shell Extensions

Review of "EasyScreenCast" version 57

Details Page Preview

EasyScreenCast

by adangel

This extension simplifies the use of the video recording function integrated in gnome shell, allows quickly to change the various settings of the desktop recording. SOURCE CODE -> https://github.com/EasyScreenCast/EasyScreenCast VIDEO -> https://youtu.be/81E9AruraKU **NOTICE** if an error occurs during the update is recommended to reload GNOME Shell (Alt + F2, 'r') and reload the extension's installation page.

Extension Homepage
https://github.com/EasyScreenCast/EasyScreenCast
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • selection.js:61 
            this._areaResolution = new St.Label({
            style_class: 'area-resolution',
            text: '',
        })
  • selection.js:50 
            this._areaSelection = new St.Widget({
            name: 'area-selection',
            style_class: 'area-selection',
            visible: 'true',
            reactive: 'true',
            x: -10,
            y: -10,
        })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • selection.js:61 
            this._areaResolution = new St.Label({
            style_class: 'area-resolution',
            text: '',
        })
  • selection.js:50 
            this._areaSelection = new St.Widget({
            name: 'area-selection',
            style_class: 'area-selection',
            visible: 'true',
            reactive: 'true',
            x: -10,
            y: -10,
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • selection.js:73 
                this._signalCapturedEvent = this._areaSelection.connect(
                'captured-event',
                this._onCaptureEvent.bind(this)
            )

All Versions

Previous Reviews on this Version

fmuellner active