Review of "Bluetooth battery indicator" version 44

Details Page Preview

Bluetooth battery indicator

Extension Homepage
https://github.com/MichalW/gnome-bluetooth-battery-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.bluetooth_battery.gschema.xml
    id='org.gnome.shell.extensions.bluetooth_battery_indicator' path='/org/gnome/shell/extensions/bluetooth_battery_indicator/'

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:7
        getPreferencesWidget() {
            const settingsController = new SettingsController(this.getSettings());
    
            return new SettingsWidget(settingsController);
        }

All Versions