GNOME Shell Extensions

Review of "Docker" version 45

Details Page Preview

Docker

by stickman_0x00

Quick access to Docker and Docker Compose. If you have suggestions on what features to add please do directly on the gitlab. ALTERNATIVE https://extensions.gnome.org/extension/2224/easy-docker-containers/ (since its a bit hidden behind multiple deprecated ones if you search by Docker and alternatives are always good)

Extension Homepage
https://gitlab.com/stickman_0x00/gnome_shell_extension_docker
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • modules/containerMenu.js:75 
    St.Clipboard.get_default()
  • ui/dialogs/information.js:83 
    St.Clipboard.get_default()
  • ui/dialogs/information.js:97 
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • ui/dialogs/information.js:19 
    		this._main_box = new St.BoxLayout({
			orientation: Clutter.Orientation.VERTICAL,
		})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • ui/dialogs/information.js:19 
    		this._main_box = new St.BoxLayout({
			orientation: Clutter.Orientation.VERTICAL,
		})

All Versions

Previous Reviews on this Version

JustPerfection active
Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.