Review of "Docker" version 46

Details Page Preview

Quick access to Docker and Docker Compose. If you have suggestions on what features to add please do directly on the gitlab. ALTERNATIVE https://extensions.gnome.org/extension/2224/easy-docker-containers/ (since its a bit hidden behind multiple deprecated ones if you search by Docker and alternatives are always good)

Extension Homepage
https://gitlab.com/stickman_0x00/gnome_shell_extension_docker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • modules/containerMenu.js:75
    St.Clipboard.get_default()
  • ui/dialogs/information.js:90
    St.Clipboard.get_default()
  • ui/dialogs/information.js:104
    St.Clipboard.get_default()

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:14
    this._settings = this.getSettings()

All Versions

Previous Reviews on this Version

JustPerfection active
stickman_0x00 posted a review
Thanks!