Review of "Smart Auto Move" version 48

Details Page Preview

Smart Auto Move learns the position, size, and workspace of your application windows and restores them on subsequent launches. Supports Wayland. NOTE: Optimized for use with static workspaces. For more control, set the default behavior to IGNORE and then selectively RESTORE only desired apps.

Extension Homepage
https://github.com/khimaros/smart-auto-move

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/state-session.js:369
    file.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/dbus.js

All Versions

Previous Reviews on this Version

JustPerfection rejected
You cannot store that and leave it after disable (line 167 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Also, blocking and unblocking the signal handler just makes the process complicated for no reason. If you simply don't want to monitor change for specific key, simply return in `_handleSettingChanged()`.
khimaros posted a review
thank you for the review. i'll address and resubmit shortly.