EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• extension.js:495

  GLib.file_get_contents(this._metadataPath())

• extension.js:683

  GLib.file_get_contents(this._metadataPath())

• extension.js:922

  GLib.file_get_contents(this._seenHistoryPath())

• extension.js:974

  GLib.file_get_contents(this._discoveredCachePath())

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:1288

              notification.connect('activated', () => {
                  Gio.AppInfo.launch_default_for_uri(pageUrl, null);
              })

• extension.js:344

          this._settingsChangedId = extension._settings.connect('changed', () => {
              if (!this.menu.isOpen)
                  return;
              GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                  if (this.menu.isOpen)
                      this._rebuildMenu();
                  return G

• extension.js:331

          this.menu.connect('open-state-changed', (menu, open) => {
              if (open)
                  this._rebuildMenu();
          })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

• extension.js:477

  this._session = new Soup.Session()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:1016

              GLib.timeout_add(GLib.PRIORITY_DEFAULT, ms, () => {
                  resolve();
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:347

              GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                  if (this.menu.isOpen)
                      this._rebuildMenu();
                  return GLib.SOURCE_REMOVE;
              })