Review of "Fresh Web Wallpaper" version 1.3 (6)

Details Page Preview

Fresh, real-world photo wallpapers from Bing, NASA or Peapix, updated automatically — pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in, favourites and banned lists, and a "Today" tab to look back at everything shown since midnight.Fresh, real-world photo wallpapers from Bing, NASA or Peapix, updated automatically, pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in (an image already shown won't be able to come back until thousands of others have been shown).

Extension Homepage
https://framagit.org/Fred6681/fresh-web-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1462
                notification.connect('activated', () => {
                    Gio.AppInfo.launch_default_for_uri(pageUrl, null);
                })
  • extension.js:427
            sitesSubMenu.menu.connect('open-state-changed', (_menu, open) => {
                this._sitesSubMenuOpen = open;
            })

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:413
                            this._idleSourceId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                                this._idleSourceId = null;
                                if (this.menu.isOpen) this._rebuildMenu();
                                return GLib.SOURCE_REMOVE;
                            })

All Versions

Version Status
2.0 (7) Unreviewed
1.3 (6) Active
1.2 (5) Inactive
1.1 (4) Inactive
1.0 (3) Inactive
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection active