Review of "Fresh Web Wallpaper" version 1.1 (4)

Details Page Preview

Fresh, real-world photo wallpapers from Bing, NASA or Peapix, updated automatically — pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in, favourites and banned lists, and a "Today" tab to look back at everything shown since midnight.Fresh, real-world photo wallpapers from Bing, NASA or Peapix, updated automatically, pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in (an image already shown won't be able to come back until thousands of others have been shown).

Extension Homepage
https://framagit.org/Fred6681/fresh-web-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 14 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:101
    console.error('system locale detection failed, falling back to en-US/us: ' + e)
  • extension.js:629
    console.error('failed to add icon to the panel: ' + e)
  • extension.js:733
    console.error('fetch failed for ' + PROVIDERS[id].label + ' (random mode): ' + e)
  • extension.js:795
    console.error('deferred accumulation failed (' + provider.label + '): ' + e)
  • extension.js:854
    console.error('failed to update wallpaper: ' + e)
  • extension.js:991
    console.error('FreshWebWallpaper: failed to write anti-repetition history: ' + e)
  • extension.js:1024
    console.error('failed to write discovered image cache: ' + e)
  • extension.js:1173
    console.error('failed to scrape page ' + page + ' (' + label + '): ' + e)
  • extension.js:1242
    console.error('initial fill failed (' + t.id + '): ' + e)
  • extension.js:1294
    console.error('re-scan failed (' + providerId + '): ' + e)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1326
    notification.connect('destroy', () => notification.disconnect(activatedId))

All Versions

Version Status
2.0 (7) Unreviewed
1.3 (6) Active
1.2 (5) Inactive
1.1 (4) Inactive
1.0 (3) Inactive
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection active
Approved but as mentioned before, please remove unnecessary comments for the next version. It won't be approved with them.