Review of "Fresh Web Wallpaper" version 2.0 (7)

Details Page Preview

Fresh, real-world photo wallpapers from Bing, NASA or Peapix Spotlight, updated automatically — pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in Sources of wallpaper Peapix Spotlight Wallpaper (https://peapix.com/spotlight) Bing Wallpaper NASA Image of the Day (https://www.nasa.gov/image-of-the-day/) Two modes Wallpaper of the moment: a single fixed source, always the latest available image. Random wallpaper: picks randomly among the sources you choose (one, two, or all three) and a change frequency adjustable separately (manual, or from 1 minute to 24 hours). The two modes are mutually exclusive: enabling one disables the other. Changing a setting (source, mode, checked sites...) applies the change right away, without delay. Each wallpaper change triggers a clickable notification opening the image page in the browser.page link, save option are also accessible from the top bar menu and the settings. The top bar icon and notifications can each be hidden from the settings. Available languages English, French (Français), Spanish (Español), Portuguese (Português), Italian (Italiano), German (Deutsch)

Extension Homepage
https://framagit.org/Fred6681/fresh-web-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:769
                this._discoveredMonitor.connect('changed', () => {
                    if (this._selfWriting) return;
                    // Prefs wrote the file — reload cache from disk async then rebuild menu
                    Gio.File.new_for_path(this._discoveredCachePath()).load_bytes_async(null, (file, res)
  • extension.js:2407
                notification.connect('activated', () => {
                    Gio.AppInfo.launch_default_for_uri(pageUrl, null);
                })
  • extension.js:616
            sitesSubMenu.menu.connect('open-state-changed', (_menu, open) => {
                this._sitesSubMenuOpen = open;
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:1135
                            GLib.idle_add(GLib.PRIORITY_LOW, () => {
                                const thumbPath = this._saveThumb(destPath, imageKey);
                                this._addToTodayWallpapers(imageKey, image.imageUrl, image.pageUrl,
                                    image.title, providerId,
  • extension.js:1383
                GLib.idle_add(GLib.PRIORITY_LOW, () => {
                    const thumbPath = this._saveThumb(destPath, imageKey);
                    // Add to today's wallpaper list (after thumb is saved)
                    this._addToTodayWallpapers(imageKey, image.imageUrl, image.pageUrl,
                        
  • extension.js:1801
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 300, () => {
                        this._ensureCurrentWallpaperInToday(retriesLeft - 1);
                        return GLib.SOURCE_REMOVE;
                    })

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:585
                            this._idleSourceId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                                this._idleSourceId = null;
                                if (this.menu.isOpen) this._rebuildMenu();
                                return GLib.SOURCE_REMOVE;
                            })

All Versions

Version Status
2.1 (10) Unreviewed
2.1 (9) Rejected
2.1 (8) Rejected
2.0 (7) Rejected
1.3 (6) Active
1.2 (5) Inactive
1.1 (4) Inactive
1.0 (3) Inactive
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

Fred6681 auto- rejected
Auto-rejected because of new version 2.1 (8) was uploaded