Review of "Rounded Window Corners Native" version 1.0.0 (1)

Details Page Preview

Gives every window the rounded corners, hairline outline and drop shadow that libadwaita apps already have. All values are read from the live GTK/Adwaita theme, so light/dark, high contrast and custom themes are followed automatically. No preferences, and no GNOME Shell methods are patched.

Extension Homepage
https://github.com/ztrahmet/rounded-window-corners

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/roundedCornersEffect.js:38
    GLib.file_get_contents(file)
  • lib/styleResolver.js:73
    GLib.file_get_contents(path)

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tools/adw-probe.js

All Versions

Version Status
1.0.0 (2) Unreviewed
1.0.0 (1) Rejected

Previous Reviews on this Version

ztrahmet auto- rejected
Auto-rejected because of new version 1.0.0 (2) was uploaded