Review of "Rounded Window Corners Native" version 51.1 (6)

Details Page Preview

Gives every window the rounded corners, hairline outline and drop shadow that libadwaita apps already have. All values are read from libadwaita's stylesheet and your ~/.config/gtk-4.0/gtk.css, so light/dark, high contrast and gtk.css changes are followed automatically. Optional settings round maximized windows, choose which apps are rounded and give apps a style of their own. No GNOME Shell methods are patched.

Extension Homepage
https://github.com/ztrahmet/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance' path=''
  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance-border-inherit' path=''
  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance-border-off' path=''

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance' path=''
  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance-border-inherit' path=''
  • schemas/org.gnome.shell.extensions.rounded-window-corners-native.gschema.xml
    id='org.gnome.shell.extensions.rounded-window-corners-native.appearance-border-off' path=''

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tools/adw-probe.js

All Versions

Version Status
51.1 (8) Active
51.0 (7) Rejected
51.1 (6) Rejected
51.0 (5) Active
51.0 (4) Rejected
2.0.0 (3) Rejected
1.0.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

ztrahmet posted a review
I'll fix Shexli errors and re-upload.
ztrahmet posted a review
Follow-up: These errors come from the relocatable schemas I use for per-app/toolkit styling. They always sit under /org/gnome/shell/extensions/rounded-window-corners-native/. I tried shoving everything into a single dict, but that cost both GSettings validation and unpacking of the dict on each edit. If you agree, I'd like to avoid that and keep the current version for release.
ztrahmet auto- rejected
Auto-rejected because of new version 51.0 (7) was uploaded