Review of "Rounded Window Corners Native" version 2.0.0 (3)

Details Page Preview

Gives every window the rounded corners, hairline outline and drop shadow that libadwaita apps already have. All values are read from the live GTK/Adwaita theme, so light/dark, high contrast and custom themes are followed automatically. No preferences, and no GNOME Shell methods are patched.

Extension Homepage
https://github.com/ztrahmet/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tools/adw-probe.js

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

All Versions

Version Status
2.0.0 (3) Unreviewed
1.0.0 (2) Unreviewed
1.0.0 (1) Rejected

Previous Reviews on this Version

ztrahmet posted a review
EGO-P-003 and EGO-P-007 are the same false positives as in 1.0.0: - EGO-P-003: No custom schemas or preferences. Gio.Settings only reads the system's org.gnome.desktop.interface to follow the GTK theme. - EGO-P-007: tools/adw-probe.js is an out-of-process helper run via Gio.Subprocess to keep GTK4/Adwaita out of the compositor process. EGO-M-004 (shell-version=['51']): GNOME 51 removed Shell.GLSLEffect. Version 2.0.0 ports the shader to Clutter.ShaderEffect's snippet API, which requires GNOME Shell 51. Tested and verified on GNOME 51.beta. Shexli flags it because its version check is not yet updated for the 51 release cycle.