Review of "Rounded Window Corners Native" version 1.0.0 (2)

Details Page Preview

Gives every window the rounded corners, hairline outline and drop shadow that libadwaita apps already have. All values are read from the live GTK/Adwaita theme, so light/dark, high contrast and custom themes are followed automatically. No preferences, and no GNOME Shell methods are patched.

Extension Homepage
https://github.com/ztrahmet/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tools/adw-probe.js

All Versions

Version Status
1.0.0 (2) Unreviewed
1.0.0 (1) Rejected

Previous Reviews on this Version

ztrahmet posted a review
Both flags are false positives. GSettings: the only one I touch is org.gnome.desktop.interface (styleResolver.js:176), to read the GTK theme name. System schema, so there's nothing to ship. adw-probe.js: not imported because it's spawned as a subprocess (styleResolver.js:502). It reads libadwaita's stylesheet from the GResource inside libadwaita-1.so, which means the library has to be loaded, and I'm not dlopening GTK4 into gnome-shell.