Review of "Desktop widgets" version 1.0.2 (1)

Details Page Preview

Desktop widgets for GNOME Shell in a grid layout: clock, binary clock, calendar, weather, photos, battery rings for your device, and an MPRIS music player. In edit mode you can add, move, resize, and remove widgets directly on your desktop, then style them with custom colors, borders, radius, shadow, and opacity. A fork of Widgets (https://github.com/TheRealSourcer/widgets).

Extension Homepage
https://github.com/r3nhick/desktop-widgets

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • widgets/music/widget.js:148
    GLib.spawn_sync(null, [ffmpeg, '-y', '-v', 'error', '-i', path, pattern],
    			null, GLib.SpawnFlags.DEFAULT, null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/ru.po
    po/ru.po
  • po/desktop-widgets@r3nhick.pot
    po/desktop-widgets@r3nhick.pot
  • po/uk.po
    po/uk.po

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • widgets/music/widget.js:1203
    c.slider.connect('button-press-event', (_source, event) => this._onSliderPress(event))
  • widgets/music/widget.js:1199
    c.btnLoop.button.connect('clicked', () => this._cycleLoop())
  • widgets/music/widget.js:1200
    c.btnPrev.button.connect('clicked', callMethod('Previous'))
  • widgets/music/widget.js:1201
    c.btnPlay.button.connect('clicked', callMethod('PlayPause'))
  • widgets/music/widget.js:1202
    c.btnNext.button.connect('clicked', callMethod('Next'))
  • widgets/music/widget.js:1204
    c.slider.connect('touch-event', (_source, event) => this._onSliderTouch(event))

All Versions

Version Status
2.0.0 (5) Unreviewed
2.0.0 (4) Rejected
1.0.3 (3) Rejected
1.0.2 (2) Rejected
1.0.2 (1) Rejected

Previous Reviews on this Version

r3nhick auto- rejected
Auto-rejected because of new version 1.0.2 (2) was uploaded