Review of "Desktop widgets" version 2.0.0 (9)

Details Page Preview

Desktop widgets for GNOME Shell in a grid layout: clock, binary clock, calendar, weather, photos, battery rings for your device, and an MPRIS music player. In edit mode you can add, move, resize, and remove widgets directly on your desktop, then style them with custom colors, borders, radius, shadow, and opacity. The Notes widget uses clipboard access for copy/paste operations within the widget editor only (Ctrl+C, Ctrl+V, Ctrl+X). No data is shared with third parties. A fork of Widgets (https://github.com/TheRealSourcer/widgets).

Extension Homepage
https://github.com/r3nhick/desktop-widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • widgets/notes/widget.js:191
    St.Clipboard.get_default()
  • widgets/notes/widget.js:216
    St.Clipboard.get_default()
  • widgets/notes/widget.js:226
    St.Clipboard.get_default()
  • widgets/notes/widget.js:235
    St.Clipboard.get_default()
  • widgets/notes/widget.js:260
    St.Clipboard.get_default()

All Versions

Version Status
2.0.0 (9) Unreviewed
2.0.0 (8) Rejected
2.0.0 (7) Rejected
2.0.0 (6) Rejected
2.0.0 (5) Rejected
2.0.0 (4) Rejected
1.0.3 (3) Rejected
1.0.2 (2) Rejected
1.0.2 (1) Rejected

Previous Reviews on this Version

r3nhick posted a review
Hello reviewer, Regarding EGO-A-005 (clipboard access): The clipboard is used ONLY in the Notes widget for standard text editor functionality (copy/paste). This is already declared in the extension description as required by the guidelines: "The Notes widget uses clipboard access for copy/paste operations within the widget editor only (Ctrl+C, Ctrl+V, Ctrl+X). No data is shared with third parties." The implementation is in widgets/notes/widget.js and follows the pattern of standard text editing - clipboard access only on user keyboard shortcuts. Thank you for reviewing!
r3nhick posted a review
?