Review of "Desktop widgets" version 2.0.0 (6)

Details Page Preview

Desktop widgets for GNOME Shell in a grid layout: clock, binary clock, calendar, weather, photos, battery rings for your device, and an MPRIS music player. In edit mode you can add, move, resize, and remove widgets directly on your desktop, then style them with custom colors, borders, radius, shadow, and opacity. The Notes widget uses clipboard access for copy/paste operations within the widget editor only (Ctrl+C, Ctrl+V, Ctrl+X). No data is shared with third parties. A fork of Widgets (https://github.com/TheRealSourcer/widgets).

Extension Homepage
https://github.com/r3nhick/desktop-widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:935
    console.log(`[desktop-widgets] _checkFullscreen: hasFullscreen=${hasFullscreen}, animationsPaused=${this._animationsPaused}, windowCount=${windows.length}`)
  • extension.js:938
    console.log('[desktop-widgets] Detected fullscreen window - pausing animations')
  • extension.js:941
    console.log('[desktop-widgets] No fullscreen window - resuming animations')
  • extension.js:953
    console.log('[desktop-widgets] FULLSCREEN MODE: Pausing all widgets')
  • extension.js:958
    console.log('[desktop-widgets] ScreenTimeEngine paused')
  • extension.js:967
    console.log('[desktop-widgets] SystemMonitor polling paused')
  • extension.js:985
    console.log(`[desktop-widgets] Paused ${pausedCount} widget instances`)
  • extension.js:995
    console.log('[desktop-widgets] EXITED FULLSCREEN: Resuming all widgets')
  • extension.js:1000
    console.log('[desktop-widgets] ScreenTimeEngine resumed')
  • extension.js:1009
    console.log('[desktop-widgets] SystemMonitor polling resumed')

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • widgets/notes/widget.js:191
    St.Clipboard.get_default()
  • widgets/notes/widget.js:216
    St.Clipboard.get_default()
  • widgets/notes/widget.js:226
    St.Clipboard.get_default()
  • widgets/notes/widget.js:235
    St.Clipboard.get_default()
  • widgets/notes/widget.js:260
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:781
    this._editModeMenuItem = editItem

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Version Status
2.0.0 (9) Unreviewed
2.0.0 (8) Rejected
2.0.0 (7) Rejected
2.0.0 (6) Rejected
2.0.0 (5) Rejected
2.0.0 (4) Rejected
1.0.3 (3) Rejected
1.0.2 (2) Rejected
1.0.2 (1) Rejected

Previous Reviews on this Version

GdH rejected
Rejected because of new version was uploaded