GNOME Shell Extensions

Review of "Quick Close in Overview" version 37

Details Page Preview

Quick Close in Overview

by gtsiam

Close windows with a button click (the middle one by default) when in overview mode

Extension Homepage
https://github.com/p91paul/middleclickclose
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:234 
    action.connect(signalId, callback)
  • extension.js:96 
    				clone.connect('captured-event', (_actor, event) => {
					switch (event.type()) {
						case Clutter.EventType.BUTTON_PRESS:
							modifier_state = event.get_state();
							break;
						case Clutter.EventType.BUTTON_RELEASE:
							modifier_state &= event.get_state();
							break;
					}

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json 
    shell-version=['49', '50', '51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:25 
        getPreferencesWidget() {
        let page = new Adw.PreferencesPage();
        let group = new Adw.PreferencesGroup();

        group.add(this.buildPreference("close-button", {
            nicks: {
                primary: _("Primary"),
                middle: _("Middle"),
                second

All Versions

Version Status
37 Active
36 Active
35 Active
34 Inactive
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Rejected
20 Active
19 Rejected
18 Inactive
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
gtsiam posted a review
RE: Shexli -- signals connected by extension should be disconnected in disable() -- These are applied to window previews, which don't live long enough for it to matter. -- metadata shell-version must only include plausible stable releases and at most one development release -- Gnome 51 is not a "future release". -- 45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget -- I see no documentation indicating the getPreferencesWidget is deprecated? That seems like a nonsense warning.